lianetm commented on code in PR #16826:
URL: https://github.com/apache/kafka/pull/16826#discussion_r1721770636
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##########
@@ -3206,14 +3208,21 @@ public void testRefreshOffsetUnknownTopicOrPartition() {
assertThrows(KafkaException.class, () ->
coordinator.initWithCommittedOffsetsIfNeeded(time.timer(Long.MAX_VALUE)));
}
- @Test
- public void testRefreshOffsetNotCoordinatorForConsumer() {
+ @ParameterizedTest
+ @CsvSource({
+ "NOT_COORDINATOR, true",
+ "COORDINATOR_NOT_AVAILABLE, true",
+ "NETWORK_EXCEPTION, false",
+ })
+ public void testRefreshOffsetRetriableErrorCoordinatorLookup(Errors error,
boolean expectCoordinatorRelookup) {
Review Comment:
now that we have parametrized this test, could we simplify and remove the
existing `testRefreshOffsetLoadInProgress`, and just add another param here for
`COORDINATOR_LOAD_IN_PROGRESS` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
