chia7712 commented on PR #16833: URL: https://github.com/apache/kafka/pull/16833#issuecomment-2292360761
> you refer to the case that the maybeExpire will complete the future exceptionally, so if ever we get a response and attempt to complete the request it won't take effect because the future is already done, is that the concern? Isn't that the behaviour we want though? Send request in a fire-and-forget mode (send & fail with timeout, which will effectively disregard any potential response). I feel `fire-completed-request-and-forget` is more accurate :smile: . IMHO, re-sending a "completed/timeout" request is a weird behavior. If we do want to have send-and-forget mode for the timeout request, we can just remove `failAndRemoveExpiredFetchRequests` since `NetworkClient` can handle the timeout too. [0] https://github.com/apache/kafka/blob/21dd5cd421139d6134d738d6e7555f0db6e1f622/clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java#L537 [1] https://github.com/apache/kafka/blob/011d35237c3454d24f1933791173ba211d037969/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java#L610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
