lianetm commented on PR #16833: URL: https://github.com/apache/kafka/pull/16833#issuecomment-2292211682
Ok, I see now how that `maybeExpire` handles the "send at least once" too, great (honestly I didn't remember that, it was probably added with the latest changes for the event reaper). Regarding the issue you mention, not sure if I'm missing something, but if I get it right, you refer to the case that the `maybeExpire` will complete the future exceptionally, so if ever we get a response and attempt to complete the request it won't take effect because the future is already done, is that the concern? Isn't that the behaviour we want though? Send request in a fire-and-forget mode (send & fail with timeout, which will effectively disregard any potential response). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
