apoorvmittal10 commented on code in PR #16890:
URL: https://github.com/apache/kafka/pull/16890#discussion_r1719031580
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -697,7 +696,7 @@ private SharePartitionKey sharePartitionKey(String groupId,
TopicIdPartition top
*/
// Visible for testing.
long offsetForEarliestTimestamp(TopicIdPartition topicIdPartition) {
- // TODO: We need to know the isolation level from group configs, for
now we are passing Option.empty() for isolationLevel
+ // Isolation level is required when reading from the latest offset
hence use Option.empty() for now.
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
