junrao commented on code in PR #16890:
URL: https://github.com/apache/kafka/pull/16890#discussion_r1718851450
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -697,7 +696,6 @@ private SharePartitionKey sharePartitionKey(String groupId,
TopicIdPartition top
*/
// Visible for testing.
long offsetForEarliestTimestamp(TopicIdPartition topicIdPartition) {
- // TODO: We need to know the isolation level from group configs, for
now we are passing Option.empty() for isolationLevel
Review Comment:
It might be useful to add a comment why the isolation level can be empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
