dongnuo123 commented on code in PR #16845:
URL: https://github.com/apache/kafka/pull/16845#discussion_r1714493590
##########
tests/kafkatest/tests/client/consumer_test.py:
##########
@@ -123,9 +123,10 @@ def test_broker_rolling_bounce(self,
metadata_quorum=quorum.zk, use_new_coordina
# nodes have time to expire
self.rolling_bounce_brokers(consumer, clean_shutdown=True)
- unexpected_rebalances = consumer.num_rebalances() - num_rebalances
- assert unexpected_rebalances == 0, \
- "Broker rolling bounce caused %d unexpected group rebalances" %
unexpected_rebalances
+ if group_protocol == consumer_group.classic_group_protocol:
+ unexpected_rebalances = consumer.num_rebalances() - num_rebalances
+ assert unexpected_rebalances == 0, \
+ "Broker rolling bounce caused %d unexpected group rebalances"
% unexpected_rebalances
Review Comment:
I think it makes sense to make sure the group is fully reconciled before
taking num_rebalances. I'll add a method to check whether all partitions are
assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
