dongnuo123 commented on code in PR #16845:
URL: https://github.com/apache/kafka/pull/16845#discussion_r1711620875
##########
tests/kafkatest/tests/client/consumer_test.py:
##########
@@ -491,8 +498,10 @@ def test_broker_failure(self, clean_shutdown,
enable_autocommit, metadata_quorum
# ensure that the consumers do some work after the broker failure
self.await_consumed_messages(consumer, min_messages=1000)
- # verify that there were no rebalances on failover
- assert num_rebalances == consumer.num_rebalances(), "Broker failure
should not cause a rebalance"
+ # verify that there were no rebalances on failover for classic
protocol consumer.
+ # Currently, the consumer protocol doesn't support num_rebalances().
+ if group_protocol == consumer_group.classic_group_protocol:
+ assert num_rebalances == consumer.num_rebalances(), "Broker
failure should not cause a rebalance"
Review Comment:
Same num_rebalances issue as
[L126](https://github.com/apache/kafka/pull/16845/files#r1711605858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
