jlprat commented on code in PR #16807: URL: https://github.com/apache/kafka/pull/16807#discussion_r1709073744
########## metadata/src/main/java/org/apache/kafka/controller/OffsetControlManager.java: ########## @@ -36,7 +36,7 @@ /** * Manages read and write offsets, and in-memory snapshots. - * + * <br> Review Comment: TIL: https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#format But the knowing enough HTML and semantic HTML this makes my brain itch. `<p>` is a tag that comes with the closing pair always and it's meant to embrace a paragraph. `<br>` is the one of the few tags that is allowed to be used without a closing one, and it's solely purpose is to add break lines. But I see that Oracle recommends the use of `<p>`, so be it. ########## metadata/src/main/java/org/apache/kafka/controller/OffsetControlManager.java: ########## @@ -71,7 +71,7 @@ Builder setTime(Time time) { return this; } - public OffsetControlManager build() { + OffsetControlManager build() { Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
