gharris1727 commented on code in PR #16807:
URL: https://github.com/apache/kafka/pull/16807#discussion_r1707525317
##########
metadata/src/main/java/org/apache/kafka/controller/OffsetControlManager.java:
##########
@@ -71,7 +71,7 @@ Builder setTime(Time time) {
return this;
}
- public OffsetControlManager build() {
+ OffsetControlManager build() {
Review Comment:
nit: The Builder itself can also be package-local.
##########
metadata/src/main/java/org/apache/kafka/controller/OffsetControlManager.java:
##########
@@ -36,7 +36,7 @@
/**
* Manages read and write offsets, and in-memory snapshots.
- *
+ * <br>
Review Comment:
nit: I think `<p>` (without `</p>`) is preferred over `<br>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
