showuon commented on PR #16653: URL: https://github.com/apache/kafka/pull/16653#issuecomment-2260378629
@clolov , thanks for the comment. > 1. Should we disallow the delete-on-disable configuration to be changed to true if there is no corresponding change to the remote.storage.enable configuration? > 2. Should we flip delete-on-disable to false once remote.storage.enable has been enabled to avoid the below scenario? For (1) and (2), I think they are similar issues, but I don't think it's necessary. From the original design, the once `remote.log.disable.policy` is set to `delete`, we will keep it no matter if the topic is re-enable -> disable the remote.log.storage config. Also, changing config in the background is not happened in Kafka before, so I think we don't have to worry about it. Does that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
