showuon commented on code in PR #16653:
URL: https://github.com/apache/kafka/pull/16653#discussion_r1698323480
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -1830,12 +1872,14 @@ void doHandleFollowerPartition(TopicIdPartition
topicPartition) {
expirationRLMTaskWithFuture.cancel();
}
- followerRLMTasks.computeIfAbsent(topicPartition, topicIdPartition -> {
- RLMFollowerTask task = new RLMFollowerTask(topicIdPartition);
- LOGGER.info("Created a new follower task: {} and getting
scheduled", task);
- ScheduledFuture<?> future =
followerThreadPool.scheduleWithFixedDelay(task, 0, delayInMs,
TimeUnit.MILLISECONDS);
- return new RLMTaskWithFuture(task, future);
- });
+ if (!remoteCopyDisabled) {
Review Comment:
hmm... good point. We need the follower task to get the correct remote
offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
