kirktrue commented on code in PR #16683:
URL: https://github.com/apache/kafka/pull/16683#discussion_r1693677875
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ClassicKafkaConsumer.java:
##########
@@ -146,7 +146,7 @@ public class LegacyKafkaConsumer<K, V> implements
ConsumerDelegate<K, V> {
// to keep from repeatedly scanning subscriptions in poll(), cache the
result during metadata updates
private boolean cachedSubscriptionHasAllFetchPositions;
- LegacyKafkaConsumer(ConsumerConfig config, Deserializer<K>
keyDeserializer, Deserializer<V> valueDeserializer) {
+ ClassicKafkaConsumer(ConsumerConfig config, Deserializer<K>
keyDeserializer, Deserializer<V> valueDeserializer) {
Review Comment:
I _believe_ I've found all of the occurrences of `LegacyKafkaConsumer` in
code, comments, etc.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ClassicKafkaConsumer.java:
##########
@@ -107,7 +107,7 @@
* group protocol (from KIP-848) introduces allows users continue using the
legacy "classic" group protocol.
Review Comment:
Updated. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
