AndrewJSchofield commented on code in PR #16683:
URL: https://github.com/apache/kafka/pull/16683#discussion_r1692018116
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ClassicKafkaConsumer.java:
##########
@@ -103,11 +103,15 @@
*
* <p/>
*
- * <em>Note:</em> per its name, this implementation is left for backward
compatibility purposes. The updated consumer
- * group protocol (from KIP-848) introduces allows users continue using the
legacy "classic" group protocol.
- * This class should not be invoked directly; users should instead create a
{@link KafkaConsumer} as before.
+ * This {@link ConsumerDelegate} implementation exists for backward
compatibility to allow users to continue to use
+ * the existing classic group protocol.
Review Comment:
I think "existing" is redundant here. I suggest "classic group protocol
(pre-KIP 848)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
