loicgreffier commented on code in PR #16300:
URL: https://github.com/apache/kafka/pull/16300#discussion_r1686578244
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -916,7 +920,17 @@ public void punctuate(final ProcessorNode<?, ?, ?, ?> node,
} catch (final StreamsException e) {
Review Comment:
Well, in the `ProcessorNode` we do not handle `TaskCorruptedException` or
`TaskMigratedException` which extends `StreamsException` for example.
Unless I'm wrong these exceptions cannot be caught in the `punctuate`,
right? (I don't want to end up in a situation where we do not handle
`TaskCorruptedException` in the `process()`, but we do in the `punctuate()`)
👉 Considering `TaskCorruptedException`/`TaskMigratedException` cannot reach
`punctuate()`, we updated the PR to handle all `StreamsException` in the
`punctuate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
