cadonna commented on code in PR #16300:
URL: https://github.com/apache/kafka/pull/16300#discussion_r1686527967
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -916,7 +920,17 @@ public void punctuate(final ProcessorNode<?, ?, ?, ?> node,
} catch (final StreamsException e) {
Review Comment:
Oh, I haven't seen your comment. Sorry!
Your proposal does not change anything, right? We will still have the
situtation that if a user throws a `StreamsException` from `punctuate()` it
will not be handled. But in `process()` it will be handled.
I think, we have the following options:
1. We live with this asymmetry between `punctuate()` and `process()`.
2. We do not handle `StreamsException` in `process()`.
3. We do handle `StreamsException` in `punctuate()`.
What do you exactly mean with
> might end up with handling exceptions that are not desirable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
