lianetm commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1674309494
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -425,6 +482,7 @@ topicId, mkSortedSet(0)
assertEquals(Collections.singletonList(expectedTopicPartitions),
heartbeatRequest1.data().topicPartitions());
// Assignment did not change, so no assignment should be sent
Review Comment:
nit: I noticed that the `getHeartbeatRequest` used here has a kind of copy
of this comment, totally out of place (ln 497). Could you pls remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]