lianetm commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1674150218
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -251,23 +304,25 @@ public void testSkippingHeartbeat(final boolean
shouldSkipHeartbeat) {
@Test
public void testTimerNotDue() {
- mockStableMember();
time.sleep(100); // time elapsed < heartbeatInterval, no heartbeat
should be sent
NetworkClientDelegate.PollResult result =
heartbeatRequestManager.poll(time.milliseconds());
+
assertEquals(0, result.unsentRequests.size());
assertEquals(DEFAULT_HEARTBEAT_INTERVAL_MS - 100,
result.timeUntilNextPollMs);
+
+ when(pollTimer.remainingMs()).thenReturn(1800L);
assertEquals(DEFAULT_HEARTBEAT_INTERVAL_MS - 100,
heartbeatRequestManager.maximumTimeToWait(time.milliseconds()));
// Member in state where it should not send Heartbeat anymore
when(subscriptions.hasAutoAssignedPartitions()).thenReturn(true);
+ when(membershipManager.shouldSkipHeartbeat()).thenReturn(true);
membershipManager.transitionToFatal();
Review Comment:
uhm that's weird. The only check that should happen there is the
`shouldSkipHeartbeat`, and we're mocking it. We're doing the same in other
tests (ex. `testFencedMemberStopHeartbeatUntilItReleasesAssignmentToRejoin`),
where just mocking the `shouldSkipHeartbeat` leads to no HB as expected (no
actual transition). Could you please double check, trying to remove just ln 298
again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
