mjsax commented on code in PR #15740:
URL: https://github.com/apache/kafka/pull/15740#discussion_r1671646367
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -796,7 +797,6 @@ public <KR> KGroupedStream<KR, V> groupBy(final
KeyValueMapper<? super K, ? supe
final GroupedInternal<KR, V> groupedInternal = new
GroupedInternal<>(grouped);
final ProcessorGraphNode<K, V> selectKeyMapNode =
internalSelectKey(keySelector, new NamedInternal(groupedInternal.name()));
- selectKeyMapNode.keyChangingOperation(true);
Review Comment:
Why do we remove this? `groupBy()` does set a new key (in contrast to
`groupByKey()`) and thus it is a key-changing operation.
If this change does not break any existing tests, I would be surprised (and
we would have a test gap)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
