LQXshane commented on code in PR #15740:
URL: https://github.com/apache/kafka/pull/15740#discussion_r1650128875
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -222,21 +226,21 @@ public <KR> KStream<KR, V> selectKey(final
KeyValueMapper<? super K, ? super V,
final Named named) {
Objects.requireNonNull(mapper, "mapper can't be null");
Objects.requireNonNull(named, "named can't be null");
-
+ final boolean repartitionRequired = !(graphNode instanceof
PartitionPreservingNode);
Review Comment:
Good point about chaining operations, I got it wrong in the current
implementation, which basically passes down the partition preservation flag all
the way...
What we want to achieve is to look upstream from `markAsRepartition()` and
set the flag to `false`; nodes downstream to this call should not be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
