brenden20 commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1645190334
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -366,12 +384,12 @@ public void testFencingWhenStateIsPrepareLeaving() {
completeCallback(callbackEvent, membershipManager);
assertEquals(MemberState.UNSUBSCRIBED, membershipManager.state());
assertEquals(ConsumerGroupHeartbeatRequest.LEAVE_GROUP_MEMBER_EPOCH,
membershipManager.memberEpoch());
- verify(membershipManager).notifyEpochChange(Optional.empty(),
Optional.empty());
Review Comment:
Makes sense, I have reverted that change
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -386,15 +404,16 @@ public void
testNewAssignmentIgnoredWhenStateIsPrepareLeaving() {
receiveAssignment(topicId, Arrays.asList(0, 1), membershipManager);
assertEquals(MemberState.PREPARE_LEAVING, membershipManager.state());
assertTrue(membershipManager.topicsAwaitingReconciliation().isEmpty());
- verify(membershipManager, never()).markReconciliationInProgress();
// When callback completes member should transition to LEAVING.
completeCallback(callbackEvent, membershipManager);
+ membershipManager.transitionToSendingLeaveGroup(false);
Review Comment:
Removed now
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -2457,10 +2538,7 @@ private CompletableFuture<Void>
mockRevocationNoCallbacks(boolean withAutoCommit
doNothing().when(subscriptionState).markPendingRevocation(anySet());
when(subscriptionState.rebalanceListener()).thenReturn(Optional.empty()).thenReturn(Optional.empty());
if (withAutoCommit) {
- when(commitRequestManager.autoCommitEnabled()).thenReturn(true);
- CompletableFuture<Void> commitResult = new CompletableFuture<>();
-
when(commitRequestManager.maybeAutoCommitSyncBeforeRevocation(anyLong())).thenReturn(commitResult);
- return commitResult;
Review Comment:
I have reverted changes here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
