lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1644919762
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -220,6 +233,7 @@ public void
testTransitionToReconcilingIfEmptyAssignmentReceived() {
@Test
public void testMemberIdAndEpochResetOnFencedMembers() {
+ createCommitRequestManager(false);
Review Comment:
we shouldn't need an actual `commitRequestManager` here, where we don't need
anything specific related to commits and a mock should do. I guess you could
remove it and just return a completed future for the autoCommit before
revocation :
`when(commitRequestManager.maybeAutoCommitSyncBeforeRevocation(anyLong())).thenReturn(CompletableFuture.completedFuture(null));`
Probably doing it once inside the `createMemberInStableState` will allow you
to remove most of the createCommitRequestManager calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
