AndrewJSchofield commented on code in PR #16368:
URL: https://github.com/apache/kafka/pull/16368#discussion_r1644402003
##########
server/src/main/java/org/apache/kafka/server/config/ShareGroupConfigs.java:
##########
@@ -88,9 +88,9 @@ public class ShareGroupConfigs {
public static final ConfigDef CONFIG_DEF = new ConfigDef()
.defineInternal(SHARE_GROUP_ENABLE_CONFIG, BOOLEAN,
SHARE_GROUP_ENABLE_DEFAULT, null, MEDIUM, SHARE_GROUP_ENABLE_DOC)
.define(SHARE_GROUP_DELIVERY_COUNT_LIMIT_CONFIG, INT,
SHARE_GROUP_DELIVERY_COUNT_LIMIT_DEFAULT, between(2, 10), MEDIUM,
SHARE_GROUP_DELIVERY_COUNT_LIMIT_DOC)
- .define(SHARE_GROUP_RECORD_LOCK_DURATION_MS_CONFIG, INT,
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DOC)
- .define(SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_CONFIG, INT,
SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_DOC)
- .define(SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_CONFIG, INT,
SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_DOC)
+ .define(SHARE_GROUP_RECORD_LOCK_DURATION_MS_CONFIG, INT,
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT, between(1000, 60000), MEDIUM,
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DOC)
Review Comment:
I think they do different things.
`SHARE_GROUP_RECORD_LOCK_DURATION_MS` configures the lock duration for share
groups which do not have a specific configuration.
`SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS` is the minimum value the broker
will accept for a group-specific configuration for the lock duration.
`SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS` is the maximum value the broker will
accept for a group-specific configuration for the lock duration.
Once we have KAFKA-14511, it will be possible to define the group-specific
configurations too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
