omkreddy commented on code in PR #16368:
URL: https://github.com/apache/kafka/pull/16368#discussion_r1644289936
##########
server/src/main/java/org/apache/kafka/server/config/ShareGroupConfigs.java:
##########
@@ -88,9 +88,9 @@ public class ShareGroupConfigs {
public static final ConfigDef CONFIG_DEF = new ConfigDef()
.defineInternal(SHARE_GROUP_ENABLE_CONFIG, BOOLEAN,
SHARE_GROUP_ENABLE_DEFAULT, null, MEDIUM, SHARE_GROUP_ENABLE_DOC)
.define(SHARE_GROUP_DELIVERY_COUNT_LIMIT_CONFIG, INT,
SHARE_GROUP_DELIVERY_COUNT_LIMIT_DEFAULT, between(2, 10), MEDIUM,
SHARE_GROUP_DELIVERY_COUNT_LIMIT_DOC)
- .define(SHARE_GROUP_RECORD_LOCK_DURATION_MS_CONFIG, INT,
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DOC)
- .define(SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_CONFIG, INT,
SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_DOC)
- .define(SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_CONFIG, INT,
SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_DOC)
+ .define(SHARE_GROUP_RECORD_LOCK_DURATION_MS_CONFIG, INT,
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT, between(1000, 60000), MEDIUM,
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DOC)
Review Comment:
we are setting the limit for SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT to
`between(1000, 60000)`, but at the same time the
SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_DEFAULT limits are set to
`between(30000, 3600000)`.
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT limits wont allow us to change
beyond 60000. I think we can set `atLeast(1)` for
SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT and the limits will be taken care
by min and max configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
