lianetm commented on code in PR #16291:
URL: https://github.com/apache/kafka/pull/16291#discussion_r1635524130
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -122,6 +123,48 @@ public void setup() {
this.props.put(VALUE_DESERIALIZER_CLASS_CONFIG,
StringDeserializer.class);
}
+ @Test
+ public void testOffsetFetchRequestStateToStringBase() {
+ ConsumerConfig config = mock(ConsumerConfig.class);
+ CommitRequestManager.MemberInfo memberInfo = new
CommitRequestManager.MemberInfo();
Review Comment:
@brenden20 we already have an `onMemberEpochUpdated` that you could maybe
use for this? so we don't have to add a new setter. That's the actual method
that gets called when the member gets a new epoch on the heartbeat response,
and we want to pass it on to the commit manager ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
