lianetm commented on code in PR #16291:
URL: https://github.com/apache/kafka/pull/16291#discussion_r1635453951
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1078,14 +1078,11 @@ private void chainFuture(
}
@Override
- public String toString() {
- return "OffsetFetchRequestState{" +
- "requestedPartitions=" + requestedPartitions +
- ", memberId=" + memberInfo.memberId.orElse("undefined") +
- ", memberEpoch=" + (memberInfo.memberEpoch.isPresent() ?
memberInfo.memberEpoch.get() : "undefined") +
- ", future=" + future +
- ", " + toStringBase() +
- '}';
+ public String toStringBase() {
+ return super.toStringBase() +
+ ", memberInfo=" + memberInfo +
Review Comment:
Agree with moving this up to the `RetriableRequestState`, and once there, I
would also suggest we simplify the output to show the member id and epoch
directly, something like:
```suggestion
", memberId=" + memberInfo.memberId.orElse... +
", memberEpoch=" + memberInfo.memberEpoch... +
```
`MemberInfo` is just an internal wrapper to move the 2 together, but when
seeing a toString for an OffsetFetch or OffsetCommit request, we just care
about `memberId` and `memberEpoch` (they will be included in the request to the
broker)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
