lianetm commented on code in PR #16043:
URL: https://github.com/apache/kafka/pull/16043#discussion_r1630221371
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -145,6 +154,7 @@ void runOnce() {
.map(networkClientDelegate::addAll)
.reduce(MAX_POLL_TIMEOUT_MS, Math::min);
networkClientDelegate.poll(pollWaitTimeMs, currentTimeMs);
+ maybePropagateMetadataError();
Review Comment:
Any reason to have this here instead of inside the `NetworkClientDelegate`
poll?
I would expect it inside the NetworkClientDelegate poll, which would be the
equivalent of the ConsumerNetworkClient (where the legacy consumer has this
same logic). I know here we are calling them sequentially so we'll get the same
result, but networkClientDelegate.poll is called from other places too (on
close), so we wouldn't propagate the error on those cases I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
