philipnee commented on PR #16043:
URL: https://github.com/apache/kafka/pull/16043#issuecomment-2130547360
Hey @appchemist -- I mistakenly thought this PR was #15961, sorry. if you
read ConsumerNetwokrThread#runOnce() you can see the original intention was to
explicitly define and execute the background thread operations. While putting
metadata error propagation in the network delegate might reduce code, it also
hides the intention (of checking metadata error). This is my thought:
```
void runOnce() {
...
applicationEventProcessor.process();
final long currentTimeMs = time.milliseconds();
final long pollWaitTimeMs = ...
networkClientDelegate.poll(pollWaitTimeMs, currentTimeMs);
metadataErrorHandler.maybeEmitError();
cachedMaximumTimeToWait = ...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
