cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628475710
##########
clients/src/main/resources/common/message/DescribeQuorumResponse.json:
##########
@@ -40,10 +45,27 @@
{ "name": "CurrentVoters", "type": "[]ReplicaState", "versions": "0+"
},
{ "name": "Observers", "type": "[]ReplicaState", "versions": "0+" }
]}
- ]}],
+ ]},
+ { "name": "Nodes", "type": "[]Node", "versions": "2+", "fields": [
+ { "name": "NodeId", "type": "int32", "versions": "2+",
+ "mapKey": true, "entityType": "brokerId", "about": "The ID of the
associated node" },
+ { "name": "Listeners", "type": "[]Listener",
+ "about": "The listeners of this controller", "versions": "2+",
"fields": [
+ { "name": "Name", "type": "string", "versions": "2+", "mapKey": true,
+ "about": "The name of the endpoint" },
+ { "name": "Host", "type": "string", "versions": "2+",
+ "about": "The hostname" },
+ { "name": "Port", "type": "uint16", "versions": "2+",
+ "about": "The port" },
+ { "name": "SecurityProtocol", "type": "int16", "versions": "2+",
Review Comment:
I don't see why we need `SecurityProtocol` here. We haven't exposed it
before and it can't be set by `AddRaftVoter`, etc. cc @jsancio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
