cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628472921
##########
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##########
@@ -29,19 +32,22 @@ public class QuorumInfo {
private final long highWatermark;
private final List<ReplicaState> voters;
private final List<ReplicaState> observers;
+ private final List<Node> nodes;
QuorumInfo(
int leaderId,
long leaderEpoch,
long highWatermark,
List<ReplicaState> voters,
- List<ReplicaState> observers
+ List<ReplicaState> observers,
+ List<Node> nodes
Review Comment:
It seems better to have a `Map<Integer, Node>` since we know the IDs are
unique.
##########
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##########
@@ -64,6 +70,10 @@ public List<ReplicaState> observers() {
return observers;
}
+ public List<Node> nodes() {
Review Comment:
It seems better to have a `Map<Integer, Node>` since we know the IDs are
unique.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
