dongnuo123 commented on code in PR #16145:
URL: https://github.com/apache/kafka/pull/16145#discussion_r1622806164
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -806,7 +809,29 @@ public void validateOffsetCommit(
if (memberEpoch < 0 && members().isEmpty()) return;
final ConsumerGroupMember member = getOrMaybeCreateMember(memberId,
false);
- validateMemberEpoch(memberEpoch, member.memberEpoch());
+ if (member.useClassicProtocol()) {
+ validateMemberInstanceId(member, groupInstanceId);
Review Comment:
Let's remove this validation because we have to do
`getOrMaybeCreateMember(memberId, false);` and know whether the member uses the
classic protocol before deciding whether instance id should be validated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
