sebastienviale commented on code in PR #16093:
URL: https://github.com/apache/kafka/pull/16093#discussion_r1618721638
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java:
##########
@@ -288,7 +301,31 @@ private <K, V> void forwardInternal(final ProcessorNode<K,
V, ?, ?> child,
final Record<K, V> record) {
setCurrentNode(child);
- child.process(record);
+ try {
Review Comment:
We had a lot of hesitation regarding where to put the try-catch clause.
The StreamTask#doProcess() method doesn't seem to allow us to identify the
node that throws the exception; the node will always be the source node.
This is why we decided to place the try-catch clause in the
ProcessorContextImpl#forwardInternal method
Of course, we are fully open to discussing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
