loicgreffier commented on code in PR #16093:
URL: https://github.com/apache/kafka/pull/16093#discussion_r1617686751
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -926,6 +933,11 @@ public class StreamsConfig extends AbstractConfig {
DefaultProductionExceptionHandler.class.getName(),
Importance.MEDIUM,
DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_DOC)
+ .define(PROCESSING_EXCEPTION_HANDLER_CLASS_CONFIG,
+ Type.CLASS,
+ ProcessingLogAndFailExceptionHandler.class.getName(),
+ Importance.MEDIUM,
+ PROCESSING_EXCEPTION_HANDLER_CLASS_DOC)
Review Comment:
Fixed.
This PR is part of a biggest PR that has been divided (see
https://github.com/apache/kafka/pull/15973#issuecomment-2135759433)
We planned #16092 to bring changes to `StreamsConfig` to ease the review,
but if you don't mind, we can close #16092 and let this PR changes the
`StreamsConfig`. Let me your thoughts about that
In all cases, indent has been fixed on #16092 and #16093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
