cadonna commented on code in PR #16092:
URL: https://github.com/apache/kafka/pull/16092#discussion_r1618662035
##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -1579,6 +1579,27 @@ public void
shouldDisableMetricCollectionOnMainConsumerOnly() {
);
}
+ @Test
+ public void shouldGetDefaultValueProcessingExceptionHandler() {
+ final StreamsConfig streamsConfig = new StreamsConfig(props);
+
+
assertEquals("org.apache.kafka.streams.errors.LogAndFailProcessingExceptionHandler",
streamsConfig.processingExceptionHandler().getClass().getName());
+ }
+
+ @Test
+ public void shouldOverrideDefaultProcessingExceptionHandler() {
+ props.put(StreamsConfig.PROCESSING_EXCEPTION_HANDLER_CLASS_CONFIG,
"org.apache.kafka.streams.errors.LogAndContinueProcessingExceptionHandler");
+ final StreamsConfig streamsConfig = new StreamsConfig(props);
+
+
assertEquals("org.apache.kafka.streams.errors.LogAndContinueProcessingExceptionHandler",
streamsConfig.processingExceptionHandler().getClass().getName());
+ }
+
+ @Test
+ public void testInvalidProcessingExceptionHandler() {
+ props.put(StreamsConfig.PROCESSING_EXCEPTION_HANDLER_CLASS_CONFIG,
"org.apache.kafka.streams.errors.InvalidProcessingExceptionHandler");
+ assertThrows(ConfigException.class, () -> new StreamsConfig(props));
Review Comment:
Could you please also verify the message?
```suggestion
final Exception exception = assertThrows(ConfigException.class, ()
-> new StreamsConfig(props));
assertThat(
exception.getMessage(),
containsString("<the message to verify>")
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
