cadonna commented on code in PR #16092:
URL: https://github.com/apache/kafka/pull/16092#discussion_r1618376459
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -926,6 +933,11 @@ public class StreamsConfig extends AbstractConfig {
DefaultProductionExceptionHandler.class.getName(),
Importance.MEDIUM,
DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_DOC)
+ .define(PROCESSING_EXCEPTION_HANDLER_CLASS_CONFIG,
+ Type.CLASS,
+ LogAndFailProcessingExceptionHandler.class.getName(),
+ Importance.MEDIUM,
+ PROCESSING_EXCEPTION_HANDLER_CLASS_DOC)
Review Comment:
Could you please add unit tests in `StreamsConfigTest`?
I think you need the following unit tests:
- One where config is not set to verify the default value
- One where the config is set and you get the correct instance from
`processingExceptionHandler()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
