dajac commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1614409077
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpecImpl.java:
##########
@@ -35,6 +37,11 @@ public class GroupSpecImpl implements GroupSpec {
*/
private final SubscriptionType subscriptionType;
+ /**
+ * Partitions assigned keyed by topicId.
+ */
+ private final Map<String, Map<Uuid, Set<Integer>>> assignedPartitions;
Review Comment:
This is correct. So why did you use `invertedTargetAssignment`? This is
inconsistent with your thoughts. So, I think that we should either use
targetAssignment for both or another name for both. We could perhaps use
lastTargetAssignment and invertedLastTargetAssignment if you don't want to use
targetAssignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
