rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1613924289
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpec.java:
##########
@@ -26,9 +26,9 @@
*/
public interface GroupSpec {
/**
- * @return Member metadata keyed by member Id.
+ * @return Member subscription metadata keyed by member Id.
*/
- Map<String, MemberSubscriptionSpec> members();
+ Map<String, MemberSubscriptionSpec> memberSubscriptions();
Review Comment:
I made it a collection at first, but there were a few places where I used
the key set to get all memberIds. I would have to calculate it again. I just
think it makes more sense. Every time we just want the memberId we iterate
through the memberSubscription and then get the memberId too. Let me know what
you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
