chia7712 commented on code in PR #16010:
URL: https://github.com/apache/kafka/pull/16010#discussion_r1611520594
##########
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##########
@@ -488,4 +488,26 @@ Found problem:
assertEquals(1, exitStatus)
}
}
+
+ @Test
+ def testFormatMultiEmptyDirectory(): Unit = {
Review Comment:
If we want to keep the order consistency, the `logDirs`, `emptyLogDirs`, and
others should be changed to `LinkedHashSet`/`LinkedHashMap`. Also, the
following callers have to use similar collection to keep the order. It seems to
me guaranteeing the "output order" is good but the fix will introduce many
changes to `StorageTool`.
Can we focus on fix the "repeated format" in this PR? Also, we can file a
ticket to get more discussion/consensus about "print consistent order"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
