gongxuanzhang commented on code in PR #16010:
URL: https://github.com/apache/kafka/pull/16010#discussion_r1610875448
##########
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##########
@@ -488,4 +488,26 @@ Found problem:
assertEquals(1, exitStatus)
}
}
+
+ @Test
+ def testFormatMultiEmptyDirectory(): Unit = {
Review Comment:
> There is already a similar test case
`testFormatSucceedsIfAllDirectoriesAreAvailable`, so could you please add new
check to `testFormatSucceedsIfAllDirectoriesAreAvailable`? for example, we can
split the `stream#toString` by new line literal and then check the duplicate
contents.
I think the print order should be consistent with the configuration
order,it's just as important as format once.
Additional,printing is done through callbacks,just change `HashMap` to
`linkedHashMap` seems impossible.
We will inverted order, so I think we should change related `HashMap` and
`HashSet` to `LinkedHashMap` and `LinkedHashSet` and create new Copier in each
loop.
About test cases,I will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
