dajac commented on code in PR #15964:
URL: https://github.com/apache/kafka/pull/15964#discussion_r1604417628
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/PartitionWriter.java:
##########
@@ -18,40 +18,21 @@
import org.apache.kafka.common.KafkaException;
import org.apache.kafka.common.TopicPartition;
-import org.apache.kafka.common.requests.TransactionResult;
+import org.apache.kafka.common.record.MemoryRecords;
+import org.apache.kafka.storage.internals.log.LogConfig;
import org.apache.kafka.storage.internals.log.VerificationGuard;
-import java.util.List;
import java.util.concurrent.CompletableFuture;
/**
* A simple interface to write records to Partitions/Logs. It contains the
minimum
* required for coordinators.
- *
- * @param <T> The record type.
*/
-public interface PartitionWriter<T> {
-
- /**
- * Serializer to translate T to bytes.
- *
- * @param <T> The record type.
- */
- interface Serializer<T> {
- /**
- * Serializes the key of the record.
- */
- byte[] serializeKey(T record);
-
- /**
- * Serializes the value of the record.
- */
- byte[] serializeValue(T record);
- }
+public interface PartitionWriter {
/**
* Listener allowing to listen to high watermark changes. This is meant
- * to be used in conjunction with {{@link
PartitionWriter#append(TopicPartition, List)}}.
+ * to be used in conjunction with {{@link
PartitionWriter#append(TopicPartition, VerificationGuard, MemoryRecords)}}.
Review Comment:
Intellij reports them as warning. I suppose that we would get warning when
we generate the javadoc too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
