jolshan commented on code in PR #15964:
URL: https://github.com/apache/kafka/pull/15964#discussion_r1603782316
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -1046,12 +1118,18 @@ public void run() {
result
);
- long offset =
partitionWriter.appendEndTransactionMarker(
+ long offset = partitionWriter.append(
tp,
- producerId,
- producerEpoch,
- coordinatorEpoch,
- result
+ VerificationGuard.SENTINEL,
+ MemoryRecords.withEndTransactionMarker(
+ time.milliseconds(),
Review Comment:
It seems we didn't specify this time value before. Was that a bug? I guess
it also just gets the system time in the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
