ableegoldman commented on code in PR #13965:
URL: https://github.com/apache/kafka/pull/13965#discussion_r1599572714
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
@@ -579,7 +579,7 @@ protected List<TopicPartition>
getAllTopicPartitions(List<String> sortedAllTopic
private class ConstrainedAssignmentBuilder extends
AbstractAssignmentBuilder {
private final Set<TopicPartition> partitionsWithMultiplePreviousOwners;
- private final Set<TopicPartition> allRevokedPartitions;
+ private final Map<TopicPartition, String> mayRevokedPartitions;
Review Comment:
> More options for who do not prefer 'maybe' may be:
possiblyRevokedPartitions, perhapsRevokedPartitions.
I actually considered both of those as well -- ultimately went with "maybe"
since the variables in this class are all way too long already, but I'm happy
with any of these choices 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
