ableegoldman commented on code in PR #13965:
URL: https://github.com/apache/kafka/pull/13965#discussion_r1599556043
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
@@ -58,7 +58,7 @@ public abstract class AbstractStickyAssignor extends
AbstractPartitionAssignor {
// Keep track of the partitions being migrated from one consumer to
another during assignment
// so the cooperative assignor can adjust the assignment
- protected Map<TopicPartition, String> partitionsTransferringOwnership =
new HashMap<>();
+ public Map<TopicPartition, String> partitionsTransferringOwnership = new
HashMap<>();
Review Comment:
Instead of making this public can you actually make it private and just add
a getter method that returns it? We don't want any class fields being
modifiable from the outside
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
