rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583333025
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1350,6 +1351,11 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> consumerGr
.withMembers(group.members())
.withStaticMembers(group.staticMembers())
.withSubscriptionMetadata(subscriptionMetadata)
+ .withSubscriptionType(ConsumerGroup.subscriptionType(
+ subscribedTopicsMemberCount,
+ group.numMembers(),
Review Comment:
An alternative may be to compare the counts within the Map without
considering the group size. This could work because we do not accept empty
subscriptions from a member. -> this works as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
