rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583332135
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1350,6 +1351,11 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> consumerGr
.withMembers(group.members())
.withStaticMembers(group.staticMembers())
.withSubscriptionMetadata(subscriptionMetadata)
+ .withSubscriptionType(ConsumerGroup.subscriptionType(
+ subscribedTopicsMemberCount,
+ group.numMembers(),
Review Comment:
yeah I was actually thinking the same, I saw that the member map is updated
in the getOrCreateMember step so I figured the memberCount is updated, unless a
member is removed, I'm not sure if that updates elsewhere, or I might be
overlooking something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
