splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1579872828
##########
metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java:
##########
@@ -159,4 +160,14 @@ BrokersToIsrs.PartitionsOnReplicaIterator
partitionsWithBrokerInElr(int brokerId
}
return new BrokersToIsrs.PartitionsOnReplicaIterator(topicMap, false);
}
+
+ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithElr() {
+ Map<Uuid, int[]> topicMap = new HashMap<>();
+ for (Map<Uuid, int[]> map : elrMembers.values()) {
+ if (map != null) {
Review Comment:
when would this be null? is there a particular reason we chose to use a null
array instead of an empty array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
