CalvinConfluent commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1566455070
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {
void handleUncleanBrokerShutdown(int brokerId, List<ApiMessageAndVersion>
records) {
replicationControl.handleBrokerUncleanShutdown(brokerId, records);
}
+
+ void maybeTriggerMinIsrConfigUpdate(Optional<String> topicName) throws
InterruptedException, ExecutionException {
+ appendWriteEvent("partitionUpdateForMinIsrChange",
OptionalLong.empty(),
+ () ->
replicationControl.getPartitionElrUpdatesForConfigChanges(topicName)).get();
+ }
Review Comment:
Got it, we basically only need to call the appendWriteEvents and do not wait
for the replay().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
