mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576351984
##########
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##########
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
users.get.filterNot(usersToSkip.contains).foreach { user =>
try {
val userConfigs = adminZkClient.fetchEntityConfig(ConfigType.USER,
Sanitizer.sanitize(user))
- addToResultsIfHasScramCredential(user, userConfigs, true)
+ addToResultsIfHasScramCredential(user, userConfigs, explicitUser =
true)
} catch {
case e: Exception => {
Review Comment:
Yeah in Scala braces are not required around multi-line blocks. I've not
made this change because braces are required in Java and we have the braces in
Scala all over the code base. Changing this is probably a >500 line diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
