chia7712 commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576193128
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##########
@@ -209,7 +209,7 @@ class GroupCoordinatorConcurrencyTest extends
AbstractCoordinatorConcurrencyTest
class JoinGroupOperation extends GroupOperation[JoinGroupCallbackParams,
JoinGroupCallback] {
override def responseCallback(responsePromise:
Promise[JoinGroupCallbackParams]): JoinGroupCallback = {
- val callback: JoinGroupCallback = responsePromise.success(_)
+ val callback: JoinGroupCallback = responsePromise.success
Review Comment:
This causes build error when using scala 2.12
```
[Error]
/home/chia7712/project/kafka/core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:212:57:
method with dependent type (value:
kafka.coordinator.group.GroupCoordinatorConcurrencyTest.JoinGroupCallbackParams)responsePromise.type
cannot be converted to function value
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
