mumrah commented on code in PR #15648:
URL: https://github.com/apache/kafka/pull/15648#discussion_r1549786977
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -420,6 +420,12 @@ class KafkaServer(
isZkBroker = true,
logManager.directoryIdsSet)
+ // For ZK brokers in migration mode, always delete the metadata
partition on startup.
+ KafkaRaftManager.maybeDeleteMetadataLogDir(config) match {
+ case Some(err) => logger.error("Could not delete local metadata
log dir. This is non-fatal, so continuing with startup.", err)
Review Comment:
My rationale here was that the deletion is not strictly required, but rather
an optimization for the revert-to-ZK case.
I assume RaftManager would also fail if there was some underlying I/O
problem, but failing here is probably okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
