soarez commented on code in PR #15648:
URL: https://github.com/apache/kafka/pull/15648#discussion_r1549319336
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -420,6 +420,12 @@ class KafkaServer(
isZkBroker = true,
logManager.directoryIdsSet)
+ // For ZK brokers in migration mode, always delete the metadata
partition on startup.
+ KafkaRaftManager.maybeDeleteMetadataLogDir(config) match {
+ case Some(err) => logger.error("Could not delete local metadata
log dir. This is non-fatal, so continuing with startup.", err)
Review Comment:
Should this really be non-fatal? What's the thinking behind this decision?
If there is an IO failure on the metadata log dir the broker should not
continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
